Skip to content

fix LdapServerAsnSyntax compile #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2020
Merged

fix LdapServerAsnSyntax compile #379

merged 3 commits into from
Oct 9, 2020

Conversation

tatsuya-ogawa
Copy link

HarlemSquirrel
HarlemSquirrel requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this. So you have a moment to fix the lints rubocop found?

HarlemSquirrel
HarlemSquirrel reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why move this down the page?

HarlemSquirrel
HarlemSquirrel approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit d60bb76 into ruby-ldap:master Oct 9, 2020
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tatsuya-ogawa @HarlemSquirrel @fre-jmas-tatsuya-ogawa