cleaning up tabs and trailing whitespace #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nolman we'd love to get this as part of the clean up for 1.0 (https://groups.google.com/d/msg/ruby-ldap/3y6g1Oqgvd0/vy5DaAcwF_cJ). Would you be interested in recreating this PR against the latest master? |
|
Fixed! |
| @@ -27,7 +27,7 @@ def generate(type, str) | |||
| when :sha | |||
| attribute_value = '{SHA}' + Base64.encode64(Digest::SHA1.digest(str)).chomp! | |||
| when :ssha | |||
| salt = SecureRandom.random_bytes(16) | |||
| salt = SecureRandom.random_bytes(16) | |||
|
@nolman thanks for the speedy turnaround. Could you go through your changeset and manually verify the changes? I think whatever editor/script you used to fix the whitespaces got tripped up in a few places. |
|
This should be good now. |
Merged
|
Thanks for the pull! I'll merge it in via #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly whitespace changes - there were a bunch of tab characters littered throughout and some trailing spaces.
$ git show 84a21ec -w --pretty=oneline
84a21ec remove tabs and use soft whitespaces
$