cleaning up tabs and trailing whitespace #53

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@nolman
Contributor
nolman commented Dec 7, 2012

Strictly whitespace changes - there were a bunch of tab characters littered throughout and some trailing spaces.

$ git show 84a21ec -w --pretty=oneline
84a21ec remove tabs and use soft whitespaces
$

@jch
Member
jch commented Oct 7, 2014

@nolman we'd love to get this as part of the clean up for 1.0 (https://groups.google.com/d/msg/ruby-ldap/3y6g1Oqgvd0/vy5DaAcwF_cJ). Would you be interested in recreating this PR against the latest master?

@nolman
Contributor
nolman commented Oct 7, 2014

Fixed!

@jch jch commented on an outdated diff Oct 7, 2014
lib/net/ldap/password.rb
@@ -27,7 +27,7 @@ def generate(type, str)
when :sha
attribute_value = '{SHA}' + Base64.encode64(Digest::SHA1.digest(str)).chomp!
when :ssha
- salt = SecureRandom.random_bytes(16)
+ salt = SecureRandom.random_bytes(16)
@jch
jch Oct 7, 2014 Member

This one looks a bit funky.

@jch jch commented on an outdated diff Oct 7, 2014
lib/net/snmp.rb
- end
- def to_ber
- @value.to_ber_application(2)
- end
- end
+ # SNMP 32-bit gauge.
+ # Defined in RFC1155 (Structure of Mangement Information), section 6.
+ # A 32-bit counter is an ASN.1 application [2] implicit unsigned integer.
+ # This is also indistinguishable from Unsigned32. (Need to alias them.)
+ class Gauge32
+ def initialize value
+ @value = value
+ end
+ def to_ber
+ @value.to_ber_application(2)
+ end
@jch
jch Oct 7, 2014 Member

As are these. I think this file might be screwed up because the top level module Net::SNMP is indented wrong.

@jch
Member
jch commented Oct 7, 2014

@nolman thanks for the speedy turnaround. Could you go through your changeset and manually verify the changes? I think whatever editor/script you used to fix the whitespaces got tripped up in a few places.

@jch jch self-assigned this Oct 7, 2014
@nolman
Contributor
nolman commented Oct 14, 2014

This should be good now.

@jch jch referenced this pull request Oct 14, 2014
Merged

Fix whitespace #128

@jch
Member
jch commented Oct 14, 2014

Thanks for the pull! I'll merge it in via #128

@jch jch closed this Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment