colons are ':' valid filter characters #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-net-ldap is choking on queries that work with our university LDAP using the
ldapsearch
utility. Here is an example of such a query:In this case, ruby-net-ldap would raise
Net::LDAP::LdapError: Invalid filter syntax
I've also run this query using the python ldap library and like
ldapsearch
it works fine.While debugging this I isolated the problem down to the parse_filter_branch method: the scanner doesn't include ':' in its regex when--I believe--it should. After updating the regex everything worked as expected for me. Please let me know if you have any questions.