Fix for test failures due to String encoding and ruby-openssl issues #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings with raw byte sequences misbehave in Ruby 2.0+ because the default encoding for string literals is now UTF-8. The String#b method resolves this, and was not previously available.
ssl_ber_spec showed failures on Ruby 1.9.3, 2.0.0 and 2.1.1 (OS X and Linux) which could only be resolved by manually closing the underlying connection. Changing the test to use a TCP socket did not help, so it seems to be a bug in the SSLSocket class.
|
Travis CI confirms the SSL issue + fix. Before: https://travis-ci.org/ruby-ldap/ruby-net-ldap/jobs/21085806 |
schaary
added a commit
that referenced
this pull request
Aug 4, 2014
Fix for test failures due to String encoding and ruby-openssl issues
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
Fix for test failures due to String encoding and ruby-openssl issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues were causing test failures for me:
Ruby 2.x defaults to UTF-8 encoding for string literals, so the "expected" values for the BER tests were not being compared correctly. The new
String#bmethod converts a string to ASCII-8BIT encoding without doing any actual translation.For some reason,
OpenSSL::SSL::SSLSocket#sync_closeis not working. I've tried this on two machines, across many Ruby versions and I see the same issue:All have the same problem, and all are fixed by 839c50f. I've additionally added a timeout to the test case which was failing, as the failures were causing the test suite to block on pipe read until killed.
I've tested in JRuby 1.7.9 and these changes do not introduce any new failures, but the two existing failures remain.
Test output before these changes: https://gist.github.com/smangelsdorf/9987870