Reduce rack version requirement #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rails 2.3.X requires Rack version https://github.com/rails/rails/blob/2-3-stable/actionpack/actionpack.gemspec#L14 |
|
@paulwalker is there something I can do to help get this PR accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to relax the rack requirement to allow for using this gem in Rails 2.3.X projects.
PR #110 pointed out that the gem only uses 2 methods from the Rack gem;
escapeandparse_query. A search for rack shows only calling the methods with a single parameter each. Both of these method signatures were introduced via commit rack/rack@7ed819a for version0.1of Rack.This is a change of the gemspec's version for rack to be
'>= 0.1'.