Redefining Array#dup breaks lots of other things #35
Assignees
Labels
Comments
|
Yes, I can see that this is over broad. Better to create a I’ll get a patch out shortly. |
|
Released 3.1.2 and yanked 3.1.1. |
|
Fantastic, thanks so much! |
|
should we consider reworking all the standard library monkey patches to use Refinements? |
no-reply
pushed a commit
to samvera/hyrax
that referenced
this issue
Jun 16, 2020
this is a temporary measure to fix the `sparql` gem. we need to force CircleCI to rebuild without the now yanked `3.1.1` release. see: ruby-rdf/sparql#35
|
I thought about that, but have never used them before, but we do patch a number of core classes, and the recent problem was really just my tunnel vision. If you have some time, perhaps give it a go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After a half-day of debugging, I realized that your redefinition of
Array#dup, introduced in 84f36c2, causes all kinds of things to go haywire in a Rails application. (I was inexplicably no longer able to log in.)I'm not even a conscious user of your gem, pulling it in via rdf-n3, but could you perhaps roll back that change? I suspect my case isn't the only weird interaction it will produce.
(EDIT: Just to be clear, I've confirmed that all the weird behavior I saw was a result of sparql 3.1.1, and could be fixed by commenting out that one function.)
The text was updated successfully, but these errors were encountered: