Add a separator component #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsouoliveira
force-pushed
the
add-separator-component
branch
from
7b2bce1 to
7039999
Compare
lsouoliveira
force-pushed
the
add-separator-component
branch
from
7039999 to
803d586
Compare
stephannv
requested changes
Mar 24, 2025
lib/ruby_ui/separator/separator.rb
Outdated
| end | ||
|
|
||
| def view_template(&) | ||
| public_send(@as, **attrs, &) |
There was a problem hiding this comment.
The as parameter could be a symbol, and then we could use tag phlex method here, eg.
Suggested change
| public_send(@as, **attrs, &) | |
| tag @as, **attrs, & |
There was a problem hiding this comment.
I added it as tag(@as, **attrs, &) because, without the parentheses, the syntax highlighting was incorrect:
lib/ruby_ui/separator/separator.rb
Outdated
Comment on lines
29
to
31
| data: { | ||
| orientation: @orientation | ||
| } |
There was a problem hiding this comment.
Is this data-attribute relevant (eg. for accessibility)? If not, we can remove it.
There was a problem hiding this comment.
It's only for styling, allowing different styles to be applied based on the value of data-orientation.
lsouoliveira
force-pushed
the
add-separator-component
branch
from
8ed68e1 to
eeb5945
Compare
lsouoliveira
force-pushed
the
add-separator-component
branch
from
eeb5945 to
902a364
Compare
lsouoliveira
force-pushed
the
add-separator-component
branch
from
902a364 to
b5fc427
Compare
stephannv
approved these changes
Mar 25, 2025
|
Thanks 🥳 |
|
@lsouoliveira do you mind opening a PR adding this component to the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a separator component based on the shadcn/ui separator.
horizontal | vertical.asparameterseparatorusing thedecorativeparameterDoc:
