Use devcontainers for CI workflows #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates our GitHub Actions workflows to use devcontainers instead of directly setting up the environment on the runner. This approach: - Ensures CI runs in the same environment as development - Simplifies workflow configuration - Reduces maintenance by centralizing environment setup in the devcontainer - Increases CI timeout to accommodate container build time
stephannv
approved these changes
Apr 14, 2025
| - name: Setup Node | ||
| uses: actions/setup-node@v4 | ||
| registry: ghcr.io | ||
| username: ${{ github.actor }} |
There was a problem hiding this comment.
Logs are showing this value as "cirdes". If I run will this work too?
There was a problem hiding this comment.
Let’s find this out soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our GitHub Actions workflows to use devcontainers instead of directly setting up the environment on the runner. This approach:
We now have 1 ci step instead of 3, and the ci will cache the Docker image to speed up future builds. Now we can ensure that devcontainers will not be broken.