Handle invalid encoding in the pure ruby version of CGI.escapeHTML and CGI.unescapeHTML #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y version Also, remove pointless assert_nothing_raised(ArgumentError) while here.
|
Has this change been released yet? We are trying to update JRuby's Ruby 3.0 standard library but the most current released cgi gem does not appear to have this change. If we ship with the released 0.2.0 gem we will regress on these cases. cc @ahorek |
|
these changes weren't released, but we can load the native library jruby/jruby#6777 thanks to @enebo so it's not a problem anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes @ahorek's patch from #2 and adds the test requested in #2.
Fixes #2.