Move block and method args to their own methods #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
May 16, 2022
Good call-out it just prevents the issue from happening for DAP clients. Console users will experience it, but at least can specific the depth of the stacktrace from the commandline which the DAP clients currently cannot do. |
The DAP server doesn't use the args and in some instances retrieving these is very slow. Instead make parameters_info public and have the thread_client call that directly.
|
@peterzhu2118 Could you give this a look? Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAP server doesn't use args and in some instances retrieving these is very slow. Extracted them into their own methods to prevent this form slowing down DAP requests as the data is not used.