Skip to content

Fix bug that "record on" doesn't work after stopping record once #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix bug that "record on" doesn't work after stopping record once #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39fa20
Fix bug that "record on" doesn't work after stopping record once
ono-max Jun 25, 2022
d9dc5bf
Add the test case for f39fa20
ono-max Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/debug/thread_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,8 +1019,8 @@ def wait_next_action_
# enable recording
if !@recorder
@recorder = Recorder.new
@recorder.enable
end
@recorder.enable
when :off
if @recorder&.enabled?
@recorder.disable
Expand Down
29 changes: 29 additions & 0 deletions test/console/record_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,33 @@ def test_1629263892
end
end
end

class RecordOnAfterStoppingOnceTest < TestCase
def program
<<~RUBY
1| a=1
2|
3| b=1
4|
5| c=1
6| p a
RUBY
end

def test_1656237686
debug_code(program) do
type 'record on'
type 'record off'
type 'record on'
type 'b 5'
type 'c'
assert_line_num 5
type 'step back'
assert_line_text([
/\[replay\] =>\#0\t<main> at .*/
])
type 'q!'
end
end
end
end