Skip to content

Conversation

ko1
Copy link
Collaborator

@ko1 ko1 commented Jul 1, 2022

fix #609

@st0012
Copy link
Member

st0012 commented Jul 1, 2022

I think it's great to centralize skipping logic but I don't think skip_path? is the place for it. Maybe we can have rename SkipPathHelper to SkipHelper and add something like skip? to it? So it'll be

skip?(path)

module SkipHelper
  def skip?(path)
    ThreadClient.current.management? || skip_path?(path)
  end
end

@ko1
Copy link
Collaborator Author

ko1 commented Jul 5, 2022

Good idea. Another PR.

@ko1 ko1 merged commit 3f1e8af into master Jul 5, 2022
@ko1 ko1 deleted the fix_609 branch July 5, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird behavior on catch command
2 participants