Skip to content

check in_subsession? on disconnect request #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

check in_subsession? on disconnect request #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions lib/debug/server_dap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,12 @@ def dap_setup bytes
end

def send **kw
kw[:seq] = @seq += 1
str = JSON.dump(kw)
@sock.write "Content-Length: #{str.bytesize}\r\n\r\n#{str}"
show_protocol '<', str
if sock = @sock
kw[:seq] = @seq += 1
str = JSON.dump(kw)
sock.write "Content-Length: #{str.bytesize}\r\n\r\n#{str}"
show_protocol '<', str
end
end

def send_response req, success: true, message: nil, **kw
Expand Down Expand Up @@ -319,11 +321,21 @@ def process
send_response req, breakpoints: filters

when 'disconnect'
if args.fetch("terminateDebuggee", false)
@q_msg << 'kill!'
terminate = args.fetch("terminateDebuggee", false)

if SESSION.in_subsession?
if terminate
@q_msg << 'kill!'
else
@q_msg << 'continue'
end
else
@q_msg << 'continue'
if terminate
@q_msg << 'kill!'
pause
end
end

send_response req

## control
Expand Down