-
Notifications
You must be signed in to change notification settings - Fork 35
[DOC] Changes to examples #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/fileutils.rb
Outdated
# |-- sub0 | ||
# | |-- src0.txt | ||
# | `-- src1.txt | ||
# `-- sub1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think indentation is off by one on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
lib/fileutils.rb
Outdated
# "tmp1/tmp2/t1.txt", | ||
# "tmp1/tmp3/t2.txt", | ||
# "tmp1/tmp3/t3.txt"] | ||
# tree src0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're calling the tree
method, you need to make the arguments strings.
# tree src0 | |
# tree('src0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (five places).
Fixed at cp_lr with slight difference from your suggested format. If ok, I'll fix the others. |
👍 I like this new format. Thank you. |
Much better! Thanks for the suggestion. All fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Changes to examples ruby/fileutils@346a71b2cb
Uses tree in examples for FileUtils.cp_lr.
Retains
File.exist?
only when the result will betrue
; otherwise changes toFile.file?
orFile.directory?
, which is more precise.