Skip to content

Add colorable keyword option #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2021
Merged

Add colorable keyword option #225

merged 4 commits into from
Apr 26, 2021
+83 −24

Conversation

nobu
Copy link
Member

@nobu nobu commented Apr 7, 2021 •
edited
Loading

Currently IRB::Color.colorize and IRB::Color.colorize_code refer $stdin.tty? internally.

This patch adds colorable keyword option which overrides it.

olleolleolle
olleolleolle approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The test helper method assert_equal_with_term turned out good, too!

aycabta
aycabta suggested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a backquote to b44af24 and the description of this Pull Request.

nobu added 4 commits April 8, 2021 21:46
@nobu
Added assert_equal_with_term
b690da9
@nobu
Added test_colorize
10e290f
@nobu
Assertions on non-tty
ede1289
@nobu
Added colorable keyword option
402e3f1 
Currently `IRB::Color.colorize` and `IRB::Color.colorize_code`
refer `$stdin.tty?` internally.
This patch adds `colorable` keyword option which overrides it.
@nobu nobu requested a review from aycabta April 8, 2021 12:51
@aycabta aycabta merged commit 0171ae2 into ruby:master Apr 26, 2021
@nobu nobu deleted the colorable-kwd branch June 22, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

+1 more reviewer

@aycabta aycabta aycabta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobu @olleolleolle @aycabta