Skip to content

Disable locale warning from TruffleRuby #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Disable locale warning from TruffleRuby #247

merged 1 commit into from
Jun 22, 2021

Conversation

nobu
Copy link
Member

@nobu nobu commented Jun 20, 2021 •
edited
Loading

assert_in_out_err fails due to the warnings since truffleruby/truffleruby@6b03a11.

@nobu nobu requested review from hsbt and aycabta June 21, 2021 02:58
@neko314 neko314 mentioned this pull request Jun 22, 2021
Merged
@aycabta aycabta merged commit b89e053 into ruby:master Jun 22, 2021
@eregon
Copy link
Member

eregon commented Jun 22, 2021

Thanks for the fix!
I think ideally assert_in_out_err/assert_separately should not change the locale, but that seems much harder to change now.

@nobu nobu deleted the truffleruby-test branch June 22, 2021 22:17
@eregon eregon mentioned this pull request Jun 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt Awaiting requested review from hsbt

1 more reviewer

@aycabta aycabta aycabta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobu @eregon @aycabta