-
Notifications
You must be signed in to change notification settings - Fork 8
Add jruby on windows-11-arm #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice, it works: https://github.com/ruby/jruby-dev-builder/actions/runs/14650305762/job/41114265330 Although it's quite slow: https://github.com/ruby/jruby-dev-builder/actions/runs/14650305762/usage I also noticed the version string is very confusing:
but we are on windows-arm64. |
@eregon I think that's because we're running x64 JDK under emulation? - The version correctly reports arm64 when I use |
Mmh, so windows-11-arm has a JAVA_HOME_21_X64 variable and that's a x64 JDK? |
So this is indeed x64 JDK, it's actually printed in the log here: https://github.com/ruby/jruby-dev-builder/actions/runs/14650305762/job/41114265330#step:18:6
I also tested with the two variable swapped and it still ended up with the same JAVA_HOME... I think only x64 JDK is preinstalled on arm64 image right now. |
Indeed: https://github.com/eregon/actions-shell/actions/runs/14660751736/job/41144475809 |
I also checked and |
For now I will remove |
It’s actually this repository: https://github.com/actions/partner-runner-images/issues You can see lots of existing issues about other tools only having x64 version preinstalled. I wouldn’t really consider this as a blocker:
|
But that seems pointless to me at least, might as well run on x64 Windows like
I prefer to not provide JRuby on windows-11-arm in setup-ruby than to provide it with a gigantic trap. If you want it, please file the issue upstream, probably many others would agree this needs to be done anyway (the only valid reason I see would be if JDK 21 doesn't support windows-arm64 but that doesn't seem to be the case). And then let's focus on supporting CRuby on windows-arm64 until that's resolved. |
JRuby >=9.4.4.0 supports windows on arm: https://github.com/jruby/jruby/releases/tag/9.4.4.0
GitHub Actions recently added new windows-11-arm runner for OSS: https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/
Name
windows-11-arm
is normalized towindows-11-arm64
to align similar to how ubuntu and mac runner's names get normalized.