Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.dump does not work in version 2.7.0 when the argument is an implicit Hash #553

Closed
Uaitt opened this issue Dec 1, 2023 · 5 comments · Fixed by #554
Closed

JSON.dump does not work in version 2.7.0 when the argument is an implicit Hash #553

Uaitt opened this issue Dec 1, 2023 · 5 comments · Fixed by #554

Comments

@Uaitt
Copy link

Uaitt commented Dec 1, 2023

On version 2.6.3

JSON.dump(a:1, b:2, c:3)
#=> "{\"a\":1,\"b\":2,\"c\":3}"

On version 2.7.0

JSON.dump(a:1, b:2, c:3)
ArgumentError: wrong number of arguments (given 0, expected 1..3)

In order to get it to work in 2.7.0 you need to do:

JSON.dump({ a:1, b:2, c:3} )
#=> "{\"a\":1,\"b\":2,\"c\":3}"

The problem lies in this change 978ee15#diff-e08e7b431f64661c031319f3bbbec311665959cd74a86f605975fe62ffe8c93d
@Uaitt Uaitt changed the title JSON.dump does not work anymore when the argument is an implicit Hash JSON.dump does not work in version 2.7.0 when the argument is an implicit Hash Dec 1, 2023
@hsbt
Copy link
Member

hsbt commented Dec 1, 2023

What's your Ruby version?

@Uaitt
Copy link
Author

Uaitt commented Dec 1, 2023 •
edited
Loading

3.2.2 @hsbt

casperisfine pushed a commit to casperisfine/json that referenced this issue Dec 1, 2023
@byroot
JSON.dump: handle unenclosed hashes regression
8e0076a 
Fix: ruby#553

We can never add keyword arguments to `dump` otherwise
existing code using unenclosed hash will break.
@casperisfine casperisfine mentioned this issue Dec 1, 2023
Merged
@casperisfine
Copy link

I think I have a fix: #554

@hsbt hsbt closed this as completed in #554 Dec 1, 2023
@hsbt
Copy link
Member

hsbt commented Dec 1, 2023 •
edited
Loading

@Uaitt Thank you for your report. I will release 2.7.1 with #554 in next week.

@casperisfine Thanks always ❤️

@Uaitt
Copy link
Author

Uaitt commented Dec 1, 2023

@hsbt and @casperisfine thanks a lot for the quick fix to both of you 😃

@MihaiOnSoftware MihaiOnSoftware mentioned this issue Dec 1, 2023
Closed
JamieMagee added a commit to dependabot/dependabot-core that referenced this issue Dec 1, 2023
@JamieMagee
Fix JSON.dump argument in shared_helpers.rb
bbf7107 
See ruby/json#553
@jakecoffman jakecoffman mentioned this issue Dec 1, 2023
Merged
@tagliala tagliala mentioned this issue Dec 4, 2023
Closed
@Uaitt Uaitt mentioned this issue Dec 4, 2023
Closed
8 tasks
@klaustopher klaustopher mentioned this issue Dec 4, 2023
Merged
@CvX CvX mentioned this issue Dec 4, 2023
Closed
matzbot pushed a commit to ruby/ruby that referenced this issue Dec 5, 2023
@byroot @hsbt
[flori/json] JSON.dump: handle unenclosed hashes regression
a22ed89 
Fix: ruby/json#553

We can never add keyword arguments to `dump` otherwise
existing code using unenclosed hash will break.

ruby/json@8e0076a3f2
@mishina2228 mishina2228 mentioned this issue Dec 5, 2023
Merged
@dentarg dentarg mentioned this issue Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSON.dump: handle unenclosed hashes regression casperisfine/json
3 participants
@hsbt @casperisfine @Uaitt