Skip to content

Reject invalid number: - -.1 -e0 #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

Reject invalid number: - -.1 -e0 #735

merged 1 commit into from
Jan 20, 2025

Conversation

tompng
Copy link
Member

@tompng tompng commented Jan 20, 2025

Reject these invalid numbers

JSON.parse '-' # => 0
JSON.parse '-.1' # => -0.1
JSON.parse '-e0' # => segmentation fault

@byroot byroot merged commit 8f1bba3 into ruby:master Jan 20, 2025
33 checks passed
@tompng tompng deleted the fix_invalid_number branch January 20, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @byroot