-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Timeout.timeout in Net:HTTP#connect #10
Conversation
Tests are already passing on Ruby 2.6 and 2.7, once #8 gets merged the 3.0 tests pass as well (i tested it locally to be sure). |
You need to introduce a |
@carlhoerberg agreed, but I think I'd like to get this PR accepted first and then follow up with another for adding an option for a |
Use Socket.tcp's connect_timeout option instead
All the tests are passing now that #8 got merged:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes seems a very good move to me!
When is this change expected to make it into Ruby stdlib? Ruby 3.0.1 and 3.0.2 were released since this PR has been merged but there hasn't been a new tagged release that includes this change, and it looks like those versions are still using 0.1.1. I may patch this in my Rails app, but would prefer to see it adopted into a core Ruby 😃. Forgive my ignorance, I don't understand the process of how stdlib updates are included in base Ruby install. |
Use socket timeout option instead.
See #6 for discussion