♻️ Refactor SequenceSet#dup, #clone, and #replace #505
+105
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally part of some performance improvements. But any speedup reported by the (newly added) benchmark isn't significant. So this change is more for the semantics of these methods. Changes: * don't delegate `#initialize_clone` and `#replace` to `#initialize_dup` * call `#modifying!` and copy the string in `#replace` * don't call `#modifying!` in `#initialize_dup` or `#initialize_clone` * don't copy or build the string in `#initialize_dup`. `@string` is always frozen, so the default shallow copy is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of some performance improvements. But any speedup reported by the (newly added) benchmark isn't significant. So this change is more for the semantics of these methods.
Changes:
#dup,#clone, and#newwith a SequenceSet input#initialize_cloneand#replaceto#initialize_dup#modifying!in#replace, but not in#initialize_dupor#initialize_clone#replace, but not in#initialize_dupor#initialize_clone.@stringis always frozen, so the default shallow copy is enough.