Test failures with LibreSSL

[zzak]

In b7c18e7 we added test support for LibreSSL, however I'm seeing 2 test failures:

Error: test_digest_constants(OpenSSL::TestDigest)
: RuntimeError: Unsupported digest algorithm (SHA).
/home/openssl/code/test/test_digest.rb:65:in `initialize'
/home/openssl/code/test/test_digest.rb:65:in `new'
/home/openssl/code/test/test_digest.rb:65:in `block in test_digest_constants'
     62:       algs += %w(SHA224 SHA256 SHA384 SHA512)
     63:     end
     64:     algs.each do |alg|
  => 65:       assert_not_nil(OpenSSL::Digest.new(alg))
     66:       klass = OpenSSL::Digest.const_get(alg)
     67:       assert_not_nil(klass.new)
     68:     end
/home/openssl/code/test/test_digest.rb:64:in `each'
/home/openssl/code/test/test_digest.rb:64:in `test_digest_constants'

This is the first error from the build.

Next:

Error: test_openssl_engine_digest_sha1(OpenSSL::TestEngine)
: OpenSSL::Engine::EngineError: unimplemented digest
/home/openssl/code/test/test_engine.rb:37:in `digest'
/home/openssl/code/test/test_engine.rb:37:in `test_openssl_engine_digest_sha1'
     34: 
     35:   def test_openssl_engine_digest_sha1
     36:     engine = get_engine
  => 37:     digest = engine.digest("SHA1")
     38:     assert_not_nil(digest)
     39:     data = "test"
     40:     assert_equal(OpenSSL::Digest::SHA1.digest(data), digest.digest(data))

Found here.

I'd like to resolve these and merge #36.

[zzak]

It looks like both of these test failures are due to unsupport/unimplemented openssl features in libressl.

So we probably just need to add some guards, either around these tests or whatever.

[nurse]

Error: test_digest_constants(OpenSSL::TestDigest)
: RuntimeError: Unsupported digest algorithm (SHA).

It is because LibreSSL 2.3 removed SHA-0 support. In openssl code, "SHA" means SHA-0. Therefore this failure is expected and should be ignored.

Error: test_openssl_engine_digest_sha1(OpenSSL::TestEngine)
: OpenSSL::Engine::EngineError: unimplemented digest

I seems LibreSSL 2.3's bug introduced by above commit. It defines OPENSSL_NO_SHA0. Because OpenSSL uses the macro to judge whether digest algorithm is used or not, they must remove it with the commit, but they missed a condition.

[nurse]

Sent PR to LibreSSL libressl/openbsd#57

[zzak]

@nurse Thank you for your investigation!

Will adding a skip around test_digest_constants for LibreSSL work suffice?

[nurse]

Will adding a skip around test_digest_constants for LibreSSL work suffice?

Yes only for "SHA". It must work others including "SHA1".
Maybe simply removing "SHA" from the test is fine.
How do you think, @nahi?

[nurse]

@zzak I committed 10eef96df4985d6e69f280b6ced4c567c20b5ca0 to ignore test_digest_constants

[zzak]

@nurse Thanks! I will merge here.