Actions - Use Ubuntu 20.04 for 1.1.1 CI, misc fixes #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
force-pushed
the
master-actions-update
branch
from
c8c7e53 to
04afaa9
Compare
nobu
reviewed
Nov 29, 2022
MSP-Greg
force-pushed
the
master-actions-update
branch
from
04afaa9 to
9c24dcc
Compare
Ubuntu's OpenSSL packages are somewhat special in the sense it sticks to a single TEENY/PATCH version and backports just security fixes instead of tracking the official releases. We will catch issues in rubyci.org but I think it still makes sense to check in GitHub Actions too to find this kind of issues earlier. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ubuntu-latest workflows will use Ubuntu-22.04.
'master' should test against both OpenSSL 1.1.1 and OpenSSL 3.0. Due to the above (changing 'ubuntu-latest' from 20.04 to
22.04), the mix of CI done with each OpenSSL version changes.
For the standard CI done in the 'test' jobs, this now runs the same job matrix for OpenSSL 1.1.1 and OpenSSL 3.0. Not sure if that's needed, especially with Ruby master?