Skip to content

Conversation

rhenium
Copy link
Member

@rhenium rhenium commented Jun 3, 2025

Ractor#take has been removed in Ruby master. For this test case we can use the new Ractor#value instead.

https://bugs.ruby-lang.org/issues/21262

@rhenium rhenium force-pushed the ky/bn-test-fix-ractor-value branch from 2708f76 to aae9307 Compare June 3, 2025 15:07
Ractor#take has been removed in Ruby master. For this test case we can
use the new Ractor#value instead.

https://bugs.ruby-lang.org/issues/21262
@junaruga
Copy link
Member

junaruga commented Jun 4, 2025

I see the ubuntu-20.04 cases are canceled. We need to backport the following commit fe4319c into the maint-3.1 branch if we want to pass the CI.

@junaruga
Copy link
Member

junaruga commented Jun 5, 2025

This PR looks good to me! Do you port this PR's commit to the master branch?

@rhenium rhenium merged commit df17ae4 into ruby:maint-3.1 Jun 5, 2025
47 of 56 checks passed
@rhenium
Copy link
Member Author

rhenium commented Jun 5, 2025

This PR looks good to me! Do you port this PR's commit to the master branch?

Thanks for checking. I've merged it to all active branches.

matzbot pushed a commit to ruby/ruby that referenced this pull request Jun 6, 2025
sms021019 pushed a commit to sms021019/ruby that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_bn.rb: Error: test_ractor(OpenSSL::TestBN): NoMethodError: undefined method 'take' for an instance of Ractor
2 participants