Skip to content

Conversation

jeremyevans
Copy link
Contributor

Ruby 3.5 will use Set[1, 2, 3]. This updates pp to use the same format.

The related Ruby pull request:

ruby/ruby#13488

and Redmine issues:

https://bugs.ruby-lang.org/issues/21389
https://bugs.ruby-lang.org/issues/21377

@nobu
Copy link
Member

nobu commented Oct 4, 2025

As set.rb in ruby 2.7 and later has its own pretty_print and pretty_print_cycle methods, I think we can remove these methods from pp.rb safely.
I misunderstood.
These methods were added for Set built in ruby 3.5.
That means we should adopt the new format only on 3.5, and use the methods in set.rb on 3.4 or earlier.

@nobu nobu force-pushed the set-pp branch 2 times, most recently from f48ee17 to 85cd188 Compare October 4, 2025 16:02
Ruby 3.5 will use `Set[1, 2, 3]`. This updates pp to use the same format.
@nobu nobu merged commit 507eebf into ruby:master Oct 4, 2025
24 checks passed
nobu pushed a commit to nobu/ruby that referenced this pull request Oct 5, 2025
(ruby/pp#43)

Ruby 3.5 will use `Set[1, 2, 3]`. This updates pp to use the same format.

ruby/pp@507eebf711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants