Reject p(p a, &block => value) and similar
#3669
Open
+285
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Oct 3, 2025
| bool contains_keyword_splat = false; | ||
|
|
||
| if (pm_symbol_node_label_p(argument) || accept1(parser, PM_TOKEN_EQUAL_GREATER)) { | ||
| if (argument_allowed_for_bare_hash(parser, argument)){ |
There was a problem hiding this comment.
There is very similar code here
Line 18217 in ce4abe1
I tried a few things to find code samples which force me to do the same change there as well but I did not find such code. Left it alone for now
| ^~ unexpected '=>', expecting end-of-input | ||
| ^~ unexpected '=>', ignoring it | ||
|
|
||
| p[p a, x: b => value] |
There was a problem hiding this comment.
This is code which I assumed would still be accepted with this change (see previous comment). But it is correctly rejected.
|
|
||
| not !foo 1 | ||
|
|
||
| foo(bar baz, key => value) |
There was a problem hiding this comment.
Probably already tested somewhere 🤷
They were being parsed as `p((p a, &block) => value)`. When we get to this point, we must not just have parsed a command call, always consuming the `=>` is not correct. Closes [Bug #21622]
Earlopain
force-pushed
the
bare-hash-command-call
branch
from
02c4a77 to
f189649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were being parsed as
p((p a, &block) => value). When we get to this point, we must not just have parsed a command call, always consuming the=>is not correct.Closes [Bug #21622]