show extended output on testtask fail only with verbose or trace #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbrain
suggested changes
Sep 20, 2016
lib/rake/testtask.rb
Outdated
| "[ruby #{args}]" | ||
| status = "Command failed with status (#{status.exitstatus})" | ||
| details = ": [ruby #{args}]" | ||
| fail (ARGV.include?('--trace') || @verbose) ? (status + details) : status |
There was a problem hiding this comment.
ARGV may no longer include '--trace' by the time we get here (Rakefile authors may change it). Switching to Rake.application.options.trace will keep this value.
Also, can you do one thing per line so this is easier to maintain? Like this:
message =
if Rake.application.options.trace or @verbose then
status + details
else
status
end
fail messageThere was a problem hiding this comment.
Sounds good, thanks!
drbrain
approved these changes
Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Rake::TestTask with a lot of files at once, sometimes the failure output from rake is quite overwhelming (because of the file list appended to the message "Command failed with status..."). This commit only shows that extended information if the user asks for verbose output in the Rake::TestTask or uses the --trace command when invoking rake.