Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrectly resolved arg pattern #327

Merged
merged 2 commits into from Nov 12, 2019

Conversation

@mjbellantoni
Copy link
Contributor

@mjbellantoni mjbellantoni commented Sep 27, 2019

I created addition some additional assertions in test_good_arg_patterns in advance of some changes I'm considering for TaskManager#resolve_args. During that case, I found a case that returned unexpected results. This pull contains the fix for that failing test case.

I updated some comments which didn't get updated in #269.

@hsbt hsbt merged commit 985abff into ruby:master Nov 12, 2019
1 check passed
1 check passed
codeclimate All good!
Details
@mjbellantoni mjbellantoni deleted the mjbellantoni:mjb-order-only-arg-fix branch Nov 12, 2019
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants