Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darkfish raises with --template-stylesheets option #828

Closed
scivola opened this issue Aug 18, 2021 · 1 comment · Fixed by #829
Closed

darkfish raises with --template-stylesheets option #828

scivola opened this issue Aug 18, 2021 · 1 comment · Fixed by #829

Comments

@scivola
Copy link

scivola commented Aug 18, 2021

reproduction code

rdoc --template-stylesheets hoge.css --debug
  • ruby 3.0.2
  • rdoc 6.3.2
  • fileutils 1.5.0

result

wrong number of arguments (given 3, expected 2)

cause

https://github.com/ruby/rdoc/blob/master/lib/rdoc/generator/darkfish.rb#L224

FileUtils.cp has two positional arguments and three keyword arguments at version 1.5.0 :
https://github.com/ruby/fileutils/blob/master/lib/fileutils.rb#L429
@nobu
Copy link
Member

nobu commented Aug 18, 2021

No tests for --template-stylesheets option since #205.

nobu added a commit to nobu/rdoc that referenced this issue Aug 18, 2021
@nobu
Add tests for --template-stylesheets option
1f14e44 
Fixes ruby#205
Fixes ruby#828 too
@nobu nobu mentioned this issue Aug 18, 2021
Merged
nobu added a commit to nobu/rdoc that referenced this issue Aug 18, 2021
@nobu
Add tests for --template-stylesheets option
857002a 
Also flattens `@options.template_stylesheets` when parsing the
command lines.

Fixes ruby#205
Fixes ruby#828 too
@hsbt hsbt closed this as completed in #829 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for --template-stylesheets option nobu/rdoc
2 participants
@nobu @scivola