Add source_code, homepage and changelog uris to gemspec metadata #1017
Conversation
| s.homepage = "https://ruby.github.io/rdoc" | ||
| s.licenses = ["Ruby"] | ||
|
|
||
| s.metadata["homepage_uri"] = s.homepage |
There was a problem hiding this comment.
Doesn’t rubygems.org fallback to #homepage?
There was a problem hiding this comment.
Yeah, I think a lot of tools favour homepage over metadata, but I thought it wouldn't harm to add it. Do you prefer not adding homepage_uri?
There was a problem hiding this comment.
metadata.homepage_uri value is going to be copied from homepage when metadata.homepage_uri was not given. So, it'd be better to keep metadata.homepage_uri empty if there's no special reason to specify both. We don't need to repeat what RubyGems internally does.
There was a problem hiding this comment.
There was a problem hiding this comment.
@amatsuda That method looks like just validating Specification#homepage, but nothing about metadata["homepage_uri"], no?
There was a problem hiding this comment.
Indeed! My bad, please forget about my comment above...!
Add source_code, homepage and changelog uris to the gemspec metadata. These fields are used to populate links on
rubygems.org. Also, dependabot useschangelog_urion update PRs, which is a nice convenience.