Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normal font-weight for links #1188

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Oct 7, 2024

A weight of 600 is nearly the same as heading weight, which is 700, putting too much weight on links, and makes many sidebar links require wrapping. As RDoc is rendering API documentation, many identifiers are links, but aren't being used in a context where they should stand out.

Before After
image image

The default weight works nicely, and links are already identified by color and underline on hover.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that increasing the font weight for links was unnecessary. Thanks for the PR 👍

@st0012 st0012 merged commit b53f0cb into ruby:master Oct 7, 2024
26 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 7, 2024
@st0012 st0012 added this to the v6.8.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants