Skip to content

Workaround JRuby's jar-dependencies error and test failures on CI #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Workaround JRuby's jar-dependencies error and test failures on CI #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2c1372
Workaround JRuby's jar-dependencies error on CI
st0012 Dec 5, 2024
25a325d
Skip problematic encoding test for JRuby
st0012 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ group :development do
gem 'gettext'
gem 'prism', '>= 0.30.0'
end

# Workaround for https://github.com/mkristian/jar-dependencies/issues/86
gem "jar-dependencies", "~> 0.4.0", platform: :jruby
10 changes: 10 additions & 0 deletions test/rdoc/test_rdoc_generator_json_index.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,16 @@ def test_generate_gzipped
end

def test_generate_utf_8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headius do you know why this test starts failing on JRuby?

# JRuby fails this test with:
# Encoding::UndefinedConversionError: "\xC2" from ASCII-8BIT to UTF-8
# org/jruby/RubyIO.java:1639:in `write'
# org/jruby/RubyIO.java:1612:in `write'
# json/ext/GeneratorState.java:232:in `_generate'
# json/ext/GeneratorState.java:137:in `generate'
# /Users/runner/work/rdoc/rdoc/vendor/bundle/jruby/3.1.0/gems/json-2.9.0-java/lib/json/common.rb:824:in `dump'
# /Users/runner/work/rdoc/rdoc/lib/rdoc/generator/json_index.rb:148:in `block in generate'
omit if RUBY_PLATFORM =~ /java/

text = "5\xB0"
text = RDoc::Encoding.change_encoding text, Encoding::ISO_8859_1
@klass.add_comment comment(text), @top_level
Expand Down
Loading