Skip to content

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Feb 5, 2016

This fixes #391, the fact that the lib/rdoc/generator/pot/* files are missing in the published 4.2.1 gem.

Testing done

Before:

$ git checkout master && rm -r pkg \
   && rake package \
   && find pkg/rdoc-4.2.1 -path '*pot*' \! -path '*/test/*'
...
pkg/rdoc-4.2.1/lib/rdoc/generator/pot.rb

After:

$ git checkout missing_pot && rm -r pkg \
   && rake package \
   && find pkg/rdoc-4.2.1 -path '*pot*' \! -path '*/test/*'
...
pkg/rdoc-4.2.1/lib/rdoc/generator/pot.rb
pkg/rdoc-4.2.1/lib/rdoc/generator/pot
pkg/rdoc-4.2.1/lib/rdoc/generator/pot/message_extractor.rb
pkg/rdoc-4.2.1/lib/rdoc/generator/pot/po_entry.rb
pkg/rdoc-4.2.1/lib/rdoc/generator/pot/po.rb

@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 5, 2016

The Travis failure was a benchmark on Ruby 2.1:

TestRDocContext#bench_add_include [/home/travis/build/rdoc/rdoc/test/test_rdoc_context.rb:419]:

Expected 0.8893409014024847 to be >= 0.9.

I've found this same benchmark to be flaky, before and after my change, and I was using Ruby 2.2.

zzak pushed a commit that referenced this pull request Feb 6, 2016
Include lib/rdoc/generator/pot/* in built gem
@zzak zzak merged commit 1ed5b5e into ruby:master Feb 6, 2016
@zzak
Copy link
Member

zzak commented Feb 6, 2016

@tjkirch Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib/rdoc/generator/pot/* not included in the 4.2.1 gem
2 participants