Skip to content

Use File.open instead of Kernel#open. #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2018
Merged

Use File.open instead of Kernel#open. #583

merged 1 commit into from
Jan 5, 2018

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 5, 2018

Ruby core team will warn to use Kernel#open in standard libraries of Ruby 2.6/3.0.

NOTE: This is not vulnerability fixes.

@hsbt
Use File.open instead of Kernel#open.
4a8c6ba 
  We should use safety method.
@hsbt hsbt requested a review from aycabta January 5, 2018 07:14
aycabta
aycabta approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@aycabta aycabta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aycabta aycabta merged commit 51539d3 into master Jan 5, 2018
@hsbt hsbt deleted the use-file-open branch January 5, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aycabta aycabta aycabta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsbt @aycabta