Fix random NameError of RipperStateLex #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because RDoc::RipperStatelex is loaded by RDoc::Parser, some tests that need RDoc::RipperStateLex fail when RDoc::Parser isn't autoloaded. That whether RDoc::RipperStateLex is loaded or not depends on RDoc::Parser is autoloaded. Therefore NameError of RDoc::RipperStateLex is occurred at random. This patch fixes it with that RDoc::RipperStateLex is moved to RDoc::Parser::RipperStateLex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
RDoc::RipperStatelexis loaded byRDoc::Parser, some tests that needRDoc::RipperStateLexfail whenRDoc::Parserisn't autoloaded. That whetherRDoc::RipperStateLexis loaded or not depends onRDoc::Parseris autoloaded. ThereforeNameErrorofRDoc::RipperStateLexis occurred at random.This patch fixes it with that
RDoc::RipperStateLexis moved toRDoc::Parser::RipperStateLex.