Skip to content

Allow a label in a link to another document text #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2021
Merged

Allow a label in a link to another document text #804

merged 3 commits into from
Jul 1, 2021

Conversation

nobu
Copy link
Member

@nobu nobu commented Apr 9, 2021

No description provided.

olleolleolle
olleolleolle approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 As the tests show, this adds URL fragment support to the these links.

@nobu nobu force-pushed the rdoc-links-label branch from aa9e121 to b46bb63 Compare May 14, 2021 16:17
@nobu nobu force-pushed the rdoc-links-label branch from 9c0adff to bbd8cf0 Compare June 28, 2021 06:44
aycabta
aycabta suggested changes Jun 30, 2021
View reviewed changes
@nobu nobu force-pushed the rdoc-links-label branch from bbd8cf0 to 424bd5d Compare June 30, 2021 20:39
@nobu nobu requested a review from aycabta June 30, 2021 20:39
@aycabta
Copy link
Member

aycabta commented Jul 1, 2021

💪

@aycabta aycabta merged commit 5341dbe into ruby:master Jul 1, 2021
@nobu nobu deleted the rdoc-links-label branch July 1, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

+1 more reviewer

@aycabta aycabta aycabta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobu @aycabta @olleolleolle