Skip to content

Update @wasmer/wasi to v1.2.2 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2023
Merged

Update @wasmer/wasi to v1.2.2 #163

merged 4 commits into from
Feb 10, 2023

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Feb 5, 2023 •
edited
Loading

To update @wasmer/wasi, this PR contains the following changes.

  • Update browser.ts for the @wasmer/wasi change.
  • Fix consolePrint implementation because @wasmer/wasi now does not expose fs bindings.
    • We hack wasi_snapshot_preview1.fd_write instead of fs.writeSync hack. They seem both dirty.

kateinoigakukun
kateinoigakukun approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit bcc4c30 into ruby:main Feb 10, 2023
@makenowjust makenowjust deleted the wasmer-1.2 branch February 13, 2023 13:00
@kateinoigakukun kateinoigakukun mentioned this pull request Mar 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makenowjust @kateinoigakukun