Skip to content

Set encoding of JS::Object#to_s result string to UTF-8 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Set encoding of JS::Object#to_s result string to UTF-8 #170

merged 1 commit into from
Feb 28, 2023

Conversation

makenowjust
Copy link
Contributor

A byte sequence of a string given by JS is encoded in UTF-8, so we want to be encoded in UTF-8 even in Ruby.

@makenowjust
Set encoding of JS::Object#to_s result string to UTF-8
df1d9c2 
A byte sequence of a string given by JS is encoded in UTF-8, so we want
to be encoded in UTF-8 even in Ruby.
kateinoigakukun
kateinoigakukun approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@kateinoigakukun kateinoigakukun merged commit 0ef6903 into ruby:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makenowjust @kateinoigakukun