Skip to content

Re-design evalAsync and reject illegal API use for safety #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 18, 2023
Merged

Re-design evalAsync and reject illegal API use for safety #220

merged 19 commits into from
May 18, 2023

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented May 17, 2023 •
edited
Loading

Resolve a part of #219

This PR changes to:

  • Reject illegal use of nested VM operation
  • Remove unnecessary Fiber switch in JS::Object#await
  • Raise an exception if JS::Object#await is used in RubyVM.eval (not in RubyVM.evalAsync)
  • Fix potential dangling promise issue in JS::Object#await, which is revealed by Is @is_spinning necessary? #205

It's already too large a change, so 2. of #219 will be another PR

@kateinoigakukun kateinoigakukun force-pushed the katei/re-design-eval-async branch from ba7d408 to ef9e6f2 Compare May 18, 2023 08:11
@kateinoigakukun kateinoigakukun marked this pull request as ready for review May 18, 2023 09:35
@kateinoigakukun kateinoigakukun changed the title Re-design evalAsync Re-design evalAsync and reject illegal API use for safety May 18, 2023
@kateinoigakukun kateinoigakukun force-pushed the katei/re-design-eval-async branch from 273235a to 84d1d34 Compare May 18, 2023 09:40
@kateinoigakukun kateinoigakukun force-pushed the katei/re-design-eval-async branch from 84d1d34 to 9177705 Compare May 18, 2023 09:42
@kateinoigakukun kateinoigakukun merged commit 00761a7 into main May 18, 2023
@kateinoigakukun kateinoigakukun deleted the katei/re-design-eval-async branch May 18, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun