Create a JavaScript object with the new method. #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new method of a JavaScript object is called by Ruby, it calls the constructor of the JavaScript runtime.
kateinoigakukun
requested changes
Jul 20, 2023
Add a class to create a JavaScript array from a Ruby array to be specified as an argument to Reflect.construct.
We do not want to define a wrapper class like JS::Array to avoid complex type conversion round trips.
ledsun
commented
Jul 22, 2023
This is to handle objects other than plain old data.
We have changed the name to Standard built-in objects, referring to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects.
kateinoigakukun
approved these changes
Jul 22, 2023
This was referenced Jul 23, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is an example of using Ruby to generate a JavaScript object:
In this pull request, you can write
So when the new method of the JavaScript object is called from Ruby, the constructor of the JavaScript runtime is called.