Skip to content

Improve Array#to_js speed #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Improve Array#to_js speed #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ext/js/lib/js/array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ class Array
# Convert Ruby array to JavaScript array
def to_js
new_array = JS.eval("return []")
self.each do |element|
# NOTE: This method call implicitly convert element to JS object by to_js
new_array.push element
end
# NOTE: This method call implicitly convert element to JS object by to_js
new_array.push *self
new_array
end
end