Support AOT dynamic extension linking #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the issue that `RUBYARCHDIR` is not re-mkdir'd when the installation directory is re-created and the extension library is re-built.
We no longer need `wasm-tools` cli
kateinoigakukun
changed the title
kateinoigakukun
changed the title
To avoid pack/unpack overhead, use magnus's TryConvert trait implementation for bytes::Bytes.
To make it easier to remove the legacy one later
Because rake-compiler 1.5.0 does not support x64-mingw32 with recent Ruby versions, and they use x64-mingw-ucrt instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RUBY_WASM_EXPERIMENTAL_DYNAMIC_LINKING=1by usingwit-component--target-rbconfigto build extension library: https://bugs.ruby-lang.org/issues/20345