Skip to content

Test against ruby verions 3.3 in workflows #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

indigolain
Copy link
Contributor

I believe ruby.wasm supports ruby versions 3.2 and 3.3. Should we test against these versions?

@indigolain indigolain marked this pull request as ready for review April 27, 2024 13:53
@kateinoigakukun
Copy link
Member

Actually we already test for each target Ruby version, so it seems too much for me to test for each "host Ruby version".

@indigolain
Copy link
Contributor Author

indigolain commented Apr 27, 2024

I see! Should we test against 3.3, the latest version, in the workflow then?

@kateinoigakukun
Copy link
Member

Yes, that sounds reasonable to me! Thanks!

@indigolain indigolain changed the title Test against ruby verions 3.2 and 3.3 Test against ruby verions 3.3 in workflows Apr 27, 2024
@indigolain
Copy link
Contributor Author

@kateinoigakukun
Thank you for the quick review! I fixed the codes to test against ruby 3.3 with 9eefed6

Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 3e7805b into ruby:main Apr 27, 2024
@indigolain indigolain deleted the test-against-ruby-3-3-in-workflows branch April 27, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants