ZJIT: Name enum for bindgen (#14802)

tekknolagi · web-flow · commit 09e5c5eed1ee · 2025-10-09T17:06:49.000Z
Relying on having the same compiler version and behavior across platforms is brittle, as Kokubun points out. Instead, name the enum so we don't have to rely on gensym stability. Fix Shopify#787
diff --git a/zjit.c b/zjit.c
@@ -235,7 +235,7 @@ rb_zjit_print_exception(void)
     rb_warn("Ruby error: %"PRIsVALUE"", rb_funcall(exception, rb_intern("full_message"), 0));
 }
 
-enum {
+enum zjit_exported_constants {
     RB_INVALID_SHAPE_ID = INVALID_SHAPE_ID,
 };
 
diff --git a/zjit/bindgen/src/main.rs b/zjit/bindgen/src/main.rs
@@ -290,7 +290,7 @@ fn main() {
         .allowlist_function("rb_zjit_insn_leaf")
         .allowlist_type("robject_offsets")
         .allowlist_type("rstring_offsets")
-        .allowlist_var("RB_INVALID_SHAPE_ID")
+        .allowlist_type("zjit_exported_constants")
         .allowlist_function("rb_assert_holding_vm_lock")
         .allowlist_function("rb_jit_shape_too_complex_p")
         .allowlist_function("rb_jit_multi_ractor_p")
diff --git a/zjit/src/cruby_bindings.inc.rs b/zjit/src/cruby_bindings.inc.rs

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ rb_zjit_print_exception(void)`
`235`	`235`	`rb_warn("Ruby error: %"PRIsVALUE"", rb_funcall(exception, rb_intern("full_message"), 0));`
`236`	`236`	`}`
`237`	`237`
`238`		`-enum {`
	`238`	`+enum zjit_exported_constants {`
`239`	`239`	`RB_INVALID_SHAPE_ID = INVALID_SHAPE_ID,`
`240`	`240`	`};`
`241`	`241`