Always freeze strings that are in the instructions

tenderlove · eightbitraptor · tenderlove · commit 774eef692cc9 · 2024-01-12T12:20:04.000-08:00
Any objects that the instructions reference should be frozen.

Co-Authored-By: Matt Valentine-House &lt;matt@eightbitraptor.com&gt;
diff --git a/prism_compile.c b/prism_compile.c
@@ -757,7 +757,7 @@ pm_interpolated_node_compile(pm_node_list_t *parts, rb_iseq_t *iseq, NODE dummy_
                         ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));
                     }
                     else {
-                        ADD_INSN1(ret, &dummy_line_node, putstring, current_string);
+                        ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));
                     }
                     current_string = Qnil;
                     number_of_items_pushed++;
@@ -776,7 +776,7 @@ pm_interpolated_node_compile(pm_node_list_t *parts, rb_iseq_t *iseq, NODE dummy_
                 ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));
             }
             else {
-                ADD_INSN1(ret, &dummy_line_node, putstring, current_string);
+                ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));
             }
             current_string = Qnil;
             number_of_items_pushed++;

Original file line number	Diff line number	Diff line change
`@@ -757,7 +757,7 @@ pm_interpolated_node_compile(pm_node_list_t parts, rb_iseq_t iseq, NODE dummy_`
`757`	`757`	`ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));`
`758`	`758`	`}`
`759`	`759`	`else {`
`760`		`- ADD_INSN1(ret, &dummy_line_node, putstring, current_string);`
	`760`	`+ ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));`
`761`	`761`	`}`
`762`	`762`	`current_string = Qnil;`
`763`	`763`	`number_of_items_pushed++;`
`@@ -776,7 +776,7 @@ pm_interpolated_node_compile(pm_node_list_t parts, rb_iseq_t iseq, NODE dummy_`
`776`	`776`	`ADD_INSN1(ret, &dummy_line_node, putobject, rb_str_freeze(current_string));`
`777`	`777`	`}`
`778`	`778`	`else {`
`779`		`- ADD_INSN1(ret, &dummy_line_node, putstring, current_string);`
	`779`	`+ ADD_INSN1(ret, &dummy_line_node, putstring, rb_str_freeze(current_string));`
`780`	`780`	`}`
`781`	`781`	`current_string = Qnil;`
`782`	`782`	`number_of_items_pushed++;`