Skip to content

Commit a4e4e3b

Browse files
deivid-rodriguezmatzbot
authored andcommitted
[rubygems/rubygems] Add missing Windows job
Specs that use extension gems were failing in the new job but I noticed that they were using very non standard `extconf.rb` files. The hack being removed here was added just to make specs pass when run in ruby-core but it seems the underlying issue has been fixed now, and it's causing issues with Ruby 3.3 and Windows, so necessary so I'm removing it and moving on. rubygems/rubygems@5b78275f0e
1 parent ccffc6e commit a4e4e3b

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

spec/bundler/install/gemfile/git_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1279,7 +1279,6 @@
12791279
s.extensions = ["ext/extconf.rb"]
12801280
s.write "ext/extconf.rb", <<-RUBY
12811281
require "mkmf"
1282-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
12831282
create_makefile("foo")
12841283
RUBY
12851284
s.write "ext/foo.c", "void Init_foo() {}"

spec/bundler/install/gems/native_extensions_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
s.extensions = ["ext/extconf.rb"]
88
s.write "ext/extconf.rb", <<-E
99
require "mkmf"
10-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
1110
name = "c_extension_bundle"
1211
dir_config(name)
1312
raise "OMG" unless with_config("c_extension") == "hello"
@@ -52,7 +51,6 @@
5251
s.extensions = ["ext/extconf.rb"]
5352
s.write "ext/extconf.rb", <<-E
5453
require "mkmf"
55-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
5654
name = "c_extension_bundle"
5755
dir_config(name)
5856
raise "OMG" unless with_config("c_extension") == "hello"
@@ -97,7 +95,6 @@
9795
s.extensions = ["ext/extconf.rb"]
9896
s.write "ext/extconf.rb", <<-E
9997
require "mkmf"
100-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
10198
name = "c_extension_bundle_#{n}"
10299
dir_config(name)
103100
raise "OMG" unless with_config("c_extension_#{n}") == "#{n}"
@@ -150,7 +147,6 @@
150147
s.extensions = ["ext/extconf.rb"]
151148
s.write "ext/extconf.rb", <<-E
152149
require "mkmf"
153-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
154150
name = "c_extension_bundle"
155151
dir_config(name)
156152
raise "OMG" unless with_config("c_extension") == "hello" && with_config("c_extension_bundle-dir") == "hola"

spec/bundler/support/builders.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,8 +494,6 @@ def add_c_extension
494494
write "ext/extconf.rb", <<-RUBY
495495
require "mkmf"
496496
497-
$extout = "$(topdir)/" + RbConfig::CONFIG["EXTOUT"]
498-
499497
extension_name = "#{name}_c"
500498
if extra_lib_dir = with_config("ext-lib")
501499
# add extra libpath if --with-ext-lib is

0 commit comments

Comments
 (0)