YJIT: Different comment when only setting ec->cfp [ci skip]

XrXr · XrXr · commit f1422e4cecdb · 2023-09-06T15:32:36.000-04:00
diff --git a/yjit/src/codegen.rs b/yjit/src/codegen.rs
@@ -5226,12 +5226,13 @@ fn gen_push_frame(
     let ep = asm.sub(sp, SIZEOF_VALUE.into());
     asm.mov(cfp_opnd(RUBY_OFFSET_CFP_EP), ep);
 
-    asm.comment("switch to new CFP");
     let new_cfp = asm.lea(cfp_opnd(0));
     if set_sp_cfp {
+        asm.comment("switch to new CFP");
         asm.mov(CFP, new_cfp);
         asm.store(Opnd::mem(64, EC, RUBY_OFFSET_EC_CFP), CFP);
     } else {
+        asm.comment("set ec->cfp");
         asm.store(Opnd::mem(64, EC, RUBY_OFFSET_EC_CFP), new_cfp);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5226,12 +5226,13 @@ fn gen_push_frame(`
`5226`	`5226`	`let ep = asm.sub(sp, SIZEOF_VALUE.into());`
`5227`	`5227`	`asm.mov(cfp_opnd(RUBY_OFFSET_CFP_EP), ep);`
`5228`	`5228`
`5229`		`- asm.comment("switch to new CFP");`
`5230`	`5229`	`let new_cfp = asm.lea(cfp_opnd(0));`
`5231`	`5230`	`if set_sp_cfp {`
	`5231`	`+ asm.comment("switch to new CFP");`
`5232`	`5232`	`asm.mov(CFP, new_cfp);`
`5233`	`5233`	`asm.store(Opnd::mem(64, EC, RUBY_OFFSET_EC_CFP), CFP);`
`5234`	`5234`	`} else {`
	`5235`	`+ asm.comment("set ec->cfp");`
`5235`	`5236`	`asm.store(Opnd::mem(64, EC, RUBY_OFFSET_EC_CFP), new_cfp);`
`5236`	`5237`	`}`
`5237`	`5238`	`}`