[Bug 20151] Fix build failure of FreeBSD 14.x #10814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Bug #18997] Don't define ruby_qsort when POSIX qsort_r is available The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant. --- util.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Delete a macro that has never been used, probably added by mistake --- util.c | 7 ------- 1 file changed, 7 deletions(-)
Include headers for `ruby_qsort` only if needed If GNU `qsort_r` is available, we use the function and these headers are not used. --- util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/20151