mandatory_only_cme should not be in def
#5311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`def` (`rb_method_definition_t`) is shared by multiple callable method entries (cme, `rb_callable_method_entry_t`). There are two issues: * old -> young reference: `cme1->def->mandatory_only_cme = monly_cme` if `cme1` is young and `monly_cme` is young, there is no problem. Howevr, another old `cme2` can refer `def`, in this case, old `cme2` points young `monly_cme` and it violates gengc assumption. * cme can have different `defined_class` but `monly_cme` only has one `defined_class`. It does not make sense and `monly_cme` should be created for a cme (not `def`). To solve these issues, this patch allocates `monly_cme` per `cme`. `cme` does not have another room to store a pointer to the `monly_cme`, so this patch introduces `overloaded_cme_table`, which is weak key map `[cme] -> [monly_cme]`. `def::body::iseqptr::monly_cme` is deleted. The first issue is reported by Alan Wu.
ko1
force-pushed
the
fix_monly_cme_store
branch
from
aad4afc to
e6d6e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
def(rb_method_definition_t) is shared by multiple callablemethod entries (cme,
rb_callable_method_entry_t).There are two issues:
cme1->def->mandatory_only_cme = monly_cmeif
cme1is young andmonly_cmeis young, there is no problem.Howevr, another old
cme2can referdef, in this case, oldcme2points young
monly_cmeand it violates gengc assumption.defined_classbutmonly_cmeonly hasone
defined_class. It does not make sense andmonly_cmeshould be created for a cme (not
def).To solve these issues, this patch allocates
monly_cmepercme.cmedoes not have another room to store a pointer to themonly_cme,so this patch introduces
overloaded_cme_table, which is weak key map[cme] -> [monly_cme].def::body::iseqptr::monly_cmeis deleted.The first issue is reported by Alan Wu.