Address feedback on previous postponed job PR #9187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 12, 2023 10:45
Just removes the unneeded `prereg_` prefix from a few local var names.
With the latest version of the postponed job patchset merged, we don't actually need to go through the contortions of keeping the data in a global variable; we can just update `data` with multiple calls to rb_postponed_job_preregister.
We want to make sure that if preregister is called with different data, that the postponed job table is updated.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/postponed_job_feedback
branch
from
cb1c8bd to
683be71
Compare
|
@ko1 if you're happy with this, are you able to merge it please? 🙏 |
hsbt
reviewed
Dec 12, 2023
doc/NEWS/NEWS-3.2.0.md
Outdated
| @@ -651,6 +651,18 @@ The following APIs are updated. | |||
| Extension libraries which use this interface and built for older | |||
| versions need to rebuild with adding `init_int32` function. | |||
|
|
|||
| * `rb_postponed_job` changes | |||
There was a problem hiding this comment.
Is it intentional? This file is for Ruby 3.2.
There was a problem hiding this comment.
🤦 Nope, this is a mistake - thank you for catching it, I will push up a fix now.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/postponed_job_feedback
branch
from
683be71 to
af49814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just has some minor fixes in response to feedback in #8949
rb_postponed_job_preregisterwe finally settled on)